[BYOC][TRT] Support batch norm for all ranks <=5, and all axes #7026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevor-m
force-pushed
the
trt-batchnorm-enhance
branch
2 times, most recently
from
ae0c87b
to
27982b8
Compare
anijain2305
reviewed
Dec 3, 2020
anijain2305
approved these changes
Dec 3, 2020
|
All tests in test_tensorrt.py passed locally |
trevor-m
force-pushed
the
trt-batchnorm-enhance
branch
from
c03ece8
to
f51f808
Compare
jroesch
reviewed
Dec 6, 2020
| auto input_dims = TrtDimsToVector(input->getDimensions()); | ||
| const size_t min_rank = TRT_HAS_IMPLICIT_BATCH(params) ? 3 : 4; | ||
| const size_t max_rank = TRT_HAS_IMPLICIT_BATCH(params) ? 4 : 5; | ||
| ICHECK_LE(input_dims.size(), max_rank); |
There was a problem hiding this comment.
Could you convert these checks to use Diagnostic instead of generating an assertion, we should strive to replace most of these with end-user readable errors.
There was a problem hiding this comment.
Hi @jroesch, thanks for reviewing!
These checks are more for sanity checking, since the annotation functions in python/tvm/relay/op/contrib/tensorrt.py will filter out the unsupported ops before they ever get to this code. I don't expect users to ever see these.
Anyway, I can make a separate PR to port all of the ICHECK to Diagnostics.
zhiics
approved these changes
Dec 8, 2020
|
Thanks @trevor-m @anijain2305 @jroesch |
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Jan 20, 2021
…e#7026) * [TRT] Support batch norm for all ranks <=5, and all axis * Add return false * Fix TRT < 6 build
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jan 21, 2021
…e#7026) * [TRT] Support batch norm for all ranks <=5, and all axis * Add return false * Fix TRT < 6 build
electriclilies
pushed a commit
to electriclilies/tvm
that referenced
this pull request
Feb 18, 2021
…e#7026) * [TRT] Support batch norm for all ranks <=5, and all axis * Add return false * Fix TRT < 6 build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous batch norm only supported rank 4 inputs with axis 1 or 3. Now we support input ranks and axes 1-5.